Admin panel blob storage #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not done yet
Base: logic of encryption coded. Now service use key to encrypt and decrypt files.
BlobStorage added to git ignore
Now endpoint GetFileBase returns a File!
Audio and Image entity changes
Now in order to save new file you should use special endpoint + to read you need also special endpoint
Audio general crud operations
Implemented all CRUD operations for audio
Implemented IOption pattern
Kasterov
requested review from
Katerix,
Kotusyk,
LanchevychMaxym,
MementoMorj,
NadiaKishchuk and
Tysyatsky
oshut
reviewed
Mar 27, 2023
| public string? Description { get; set; } | ||
| public UrlDTO Url { get; set; } | ||
| public string BlobName { get; set; } | ||
|
|
|
|
||
| await _repositoryWrapper.AudioRepository.CreateAsync(audio); | ||
|
|
||
| var resultIsSuccess = await _repositoryWrapper.SaveChangesAsync() > 0; |
There was a problem hiding this comment.
don't you think that isResultSuccess or isSavingSucceeded or even just isSuccess would be more appropriate than current name?
Now when you return imageDTO or imagesDTO you also have mime-type and bae64
Tysyatsky
approved these changes
Mar 27, 2023
Contributor
Tysyatsky
left a comment
Tysyatsky
left a comment
There was a problem hiding this comment.
Great job pal! Waiting for the meeting with a guide how to work with that in future. Thank you.
Comment on lines
-36
to
-37
| [HttpPut("{id:int}")] | ||
| public async Task<IActionResult> Update([FromRoute] int id, [FromBody] AudioDTO audio) |
Contributor
There was a problem hiding this comment.
Why do you delete HttpPut attribute here but not in the next method (delete)?
MementoMorj
reviewed
Mar 31, 2023
Contributor
MementoMorj
left a comment
MementoMorj
left a comment
There was a problem hiding this comment.
OMG111AWS!!!!GOAT!!!!
Katerix
approved these changes
Mar 31, 2023
Contributor
Katerix
left a comment
Katerix
left a comment
There was a problem hiding this comment.
awesome! useful and fun blob storage)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
JIRA
Code reviewers
Second Level Review
Summary of issue
ToDo
Summary of change
ToDo
Testing approach
ToDo
CHECK LIST