Instagram api #237
Merged
Instagram api #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Katerix
requested review from
Dobriyr,
MaksBrat,
MementoMorj,
NadiaKishchuk,
Tysyatsky and
ormykhalyshyn
MementoMorj
approved these changes
May 29, 2023
Tysyatsky
approved these changes
May 29, 2023
Contributor
Tysyatsky
left a comment
Tysyatsky
left a comment
There was a problem hiding this comment.
1 comment, but overall awesome work!
|
|
||
| public async Task<IEnumerable<InstagramPost>> GetPostsAsync() | ||
| { | ||
| var postLimit = 10; |
Contributor
There was a problem hiding this comment.
why do you need two postLimit variables? Also consider defining it like a constant.
ormykhalyshyn
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
JIRA
Code reviewers
Second Level Review
Summary of issue
ToDo
Summary of change
ToDo
Testing approach
ToDo
CHECK LIST