Skip to content

Update README.md #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ormykhalyshyn merged 1 commit into from
Jun 17, 2023
Merged

Update README.md #280

ormykhalyshyn merged 1 commit into from
Jun 17, 2023

Conversation

@ormykhalyshyn
Copy link
Contributor

@ormykhalyshyn ormykhalyshyn commented Jun 17, 2023

dev

JIRA

Code reviewers

  • @ita-social-projects/lv-734-02-streetcode
  • @ita-social-projects/lv-734-03-streetcode
  • @ita-social-projects/lv-734-04-streetcode

Second Level Review

Summary of issue

Add statistics from Sonarcube to the readme file

Summary of change

Added statistics from Sonarcube to the readme file

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@ormykhalyshyn ormykhalyshyn added the documentation Improvements or additions to documentation label Jun 17, 2023
@ormykhalyshyn ormykhalyshyn requested review from a team June 17, 2023 15:43
@ormykhalyshyn ormykhalyshyn self-assigned this Jun 17, 2023
@ormykhalyshyn ormykhalyshyn linked an issue Jun 17, 2023 that may be closed by this pull request
Sonarqube #279
Closed
Dobriyr
Dobriyr approved these changes Jun 17, 2023
View reviewed changes
Copy link
Contributor

@Dobriyr Dobriyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good code

@ormykhalyshyn ormykhalyshyn merged commit 4442f8a into master Jun 17, 2023
@Lazy-Lenny Lazy-Lenny deleted the ormykhalyshyn-update-readme branch March 28, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dobriyr Dobriyr Dobriyr approved these changes

Assignees

@ormykhalyshyn ormykhalyshyn

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sonarqube

3 participants

@ormykhalyshyn @Dobriyr