In-Memory Caching Implementation #709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+60
to
+67
| public void RemoveStreetcodeCaches(int streetcodeId) | ||
| { | ||
| string cacheKeyImage = $"ImageCache_{streetcodeId}"; | ||
| string cacheKeyText = $"TextCache_{streetcodeId}"; | ||
|
|
||
| _cache.Remove(cacheKeyImage); | ||
| _cache.Remove(cacheKeyText); | ||
| } |
There was a problem hiding this comment.
Let's implement here the generic Remove method, this method shouldn't know anything about the method where it will be used.
| } | ||
|
|
||
| return Result.Ok(imageDtos); | ||
| string cacheKey = $"ImageCache_{request.StreetcodeId}"; |
There was a problem hiding this comment.
Let's move this cache keys to some standardized solution, we shouldn't hardcode this key here and in every method we need this
| public async Task<Result<TextDTO?>> Handle(GetTextByStreetcodeIdQuery request, CancellationToken cancellationToken) | ||
| { | ||
| var text = await _repositoryWrapper.TextRepository | ||
| string cacheKey = $"TextCache_{request.StreetcodeId}"; |
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
JIRA
Code reviewers
Second Level Review
Summary of issue
ToDo
Summary of change
ToDo
Testing approach
ToDo
CHECK LIST