ci: enable godox, noctx, errname, ireturn linters#345
Merged
bfabio merged 1 commit intoitalia:mainfrom Mar 25, 2026
Merged
Conversation
d5bce49 to
490b035
Compare
Member
|
@creed-bratton I'm not onboard with the godox rule. Banning TODO and FIXME outright is harmful IMO. People people will just remove them to make the linter happy and then the information is gone. |
Contributor
Author
|
Dropped Fixed the remaining violations:
|
bfabio
approved these changes
Mar 25, 2026
71a05a4 to
b2f2bd3
Compare
b2f2bd3 to
1b8c8c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables four linters that have zero violations in the current codebase.
godox — no TODO/FIXME/HACK/XXX in production code.
noctx — no direct
http.Get/http.Postcalls; the codebase uses a custom HTTP client throughout.ireturn — no bare interface returns.
MarshalYAML() (any, error)is covered by the defaultemptyallow category.errname — error types follow the convention.
ValidationWarningis the only exception: it is intentionally named as a warning even though it implementserror(it signals a non-fatal issue, not an error). A//nolint:errnameannotation documents this.recvcheck,errorlint,err113,wrapcheckwill be addressed separately as they need small code fixes.