Support for PyInstaller #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
@crwood could you try this? |
|
@itamarst My apologies for missing this earlier.. If it matters, I have since tested a non-trivial (python2) application running under a frozen/PyInstaller interpreter on Linux, macOS, and Windows and can confirm that, in all three cases, with these changes in place, eliot logging is now working as expected. Thank you very much for this -- and for eliot more generally! I'm greatly looking forward to using it in future projects. :) |
Owner
Author
|
No problem, Jean-Paul conveyed that it worked. Thanks for the further checks! |
tomprince
pushed a commit
to tp-la/eliot
that referenced
this pull request
Jul 14, 2021
Support for PyInstaller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #386.