Doesn't have an app icon on Ubuntu

[stuartlangridge]

In the Ubuntu launcher, a running itch.io desktop client (downloaded as tar.xz) doesn't have an icon specified. (You should be able to specify this when creating a BrowserWindow.)

[fasterthanlime]

Well, the code to do it is definitely there:

  const iconPath = `${__dirname}/../static/images/tray/${app.getName()}.png`

  const window = new BrowserWindow({
    title: app.getName(),
    icon: iconPath,
    width, height,
    center,
    show: false,
    autoHideMenuBar: true,
    backgroundColor: darkMineShaft,
    titleBarStyle: 'hidden'
  })

but perhaps the path can't be read from a production build, which is in an .asar archive. I wonder if I should be using file:// instead.

[stuartlangridge]

Yeah, I've just looked at the code myself and seen that. Not sure why that isn't working...

[stuartlangridge]

I think electron/electron#6205 might be relevant here!

[fasterthanlime]

Interesting! Definitely used to that kind of bugs from Electron by now ;) there's already logic in tray.js to pick a small-enough icon.

[fasterthanlime]

I wonder if I can install the Unity launcher on Debian without breaking anything (I have an Ubuntu VM somewhere, but do most of my testing on Debian).

[stuartlangridge]

Honestly, you're almost certainly better off firing up an Ubuntu VM. Unity is a bit tied to Ubuntu...

[fasterthanlime]

Applied the fix linked to in 6205, pushed a new canary build to test it, will be up soon.

[fasterthanlime]

In my ubuntu 16.04 VM, it looks like both itch 18.3.0 (latest stable) and 18.3.1-canary (beta/canary build I just pushed) have an icon in the Unity launcher when installed from .deb (with a proper .desktop file):

However, after uninstalling the .deb (important, otherwise it'll pick up the icon from /usr/share/applications), I can confirm that 18.3.0 lacked an icon, and that 18.3.1-canary has one:

Closing as this'll ship in the next stable version.