Added q! - command

[Zarathustra2]

Hey,

I have added the q! command, which discards all changes and quits the editor.
Furthermore, if someone now tries to quit with the q command while changes have not been saved, it will fail and display an error message.

Since this is my first time contributing to a go open source project, I would appreciate any feedback!

Best regards,
Dario! :)

[itchyny]

This sounds nice. I'll take a look later.

[itchyny]

I think it's better to support q[uit]! but I remember I didn't implement the parser to accept this so I'll fix this after merging.

[Zarathustra2]

Yes, I tried q[uit]! as well, but failed due to the parsing. Do you want me to add a failing test case for q[uit]! ?

[itchyny]

No, thanks. I'll take care of it.

[itchyny]

Your pull request updates unsavedChanges for only some limited operations. You can find all the changes by searching /b.buffer./, for example, window#insert, window#replace, window#cut or window#paste. Maybe changedTick is incremented as well. Also, please rename unsavedChanges to modified, which reminds me &modified of Vim.

changes sample:

@@ -356,11 +356,13 @@ func (w *window) state(width, height int) (*state.WindowState, error) {
 func (w *window) insert(offset int64, c byte) {
 	w.buffer.Insert(offset, c)
 	w.changedTick++
+	w.modified = true
 }
 
 func (w *window) replace(offset int64, c byte) {
 	w.buffer.Replace(offset, c)
 	w.changedTick++
+	w.modified = true
 }
 
 func (w *window) undoReplace(offset int64) {

[Zarathustra2]

Hey @itchyny,

Thanks for reviewing my PR! :)

I have updated the files as requested, would you mind taking another look?

Best regards!

[itchyny]

Great, thank you.

[itchyny]

Now that I improved the cmdline parser, you can use both :q!, :quit!.

[Zarathustra2]

Nice thanks! :) @itchyny