ci(review): 非 suggestion 指摘の分類・task化コアを追加 by ootakazuhiko · Pull Request #2378 · itdojp/ae-framework

ootakazuhiko · 2026-03-02T03:26:51Z

概要

非 suggestion レビュー指摘の自動処理に向けた基盤として、コメント分類器と action task 変換器を追加
PR [Sub-issue] 非 suggestion レビュー指摘の自動対応ループ実装（Codex連携） #2373 の PR-1（分類/アクション生成コア）に相当

変更内容

scripts/ci/lib/review-comment-classifier.mjs（新規）
- extractSuggestionBlocks:
  - review comment 本文から suggestion ブロックを抽出
- classifyReviewCommentBody:
  - suggestion / actionable / informational のルールベース分類
- buildActionTaskFromComment:
  - actionable comment から deterministic な task オブジェクトを生成
- summarizeActionTasks:
  - task 一覧を PR コメント向けの要約行へ変換
tests/unit/ci/review-comment-classifier.test.ts（新規）
- suggestion 抽出
- 分類ルール
- task 生成
- 要約出力

テスト

pnpm vitest run tests/unit/ci/review-comment-classifier.test.ts

Refs: #2373

github-actions · 2026-03-02T03:27:00Z

❓ Code Generation Drift Detection

Status:
Regeneration needed: No

Automated by AE-Framework Codegen

github-actions · 2026-03-02T03:27:38Z

Quality Summary

Adapters:
Formal: n/a
Replay: n/a
Trace IDs:

Harness Health

severity: warn
source: workflow=PR Maintenance, runId=22562712322, sha=4157bd4047c88c46ec073a22c7b4708b014f724b

Gate	Status	Checks
artifactsSchema	skip	0
testingHarness	warn	1
contextPack	skip	0
runtimeConformance	skip	0
ciExtended	skip	1

Change Package

risk=risk:low (inferred=risk:low) | files=0 | areas=unknown | evidence=1/4 present/missing
required labels: (none) | missing: (none)
reproducibility: pnpm run verify:lite

Change Package Validation

result: WARN
strict: false
schema: PASS
required evidence: verifyLiteSummary
missing required evidence: verifyLiteSummary
evidence present/missing(actual): 1/4
warnings:
- missing required evidence: verifyLiteSummary

github-actions · 2026-03-02T03:27:39Z

Progress Summary

Missing: metrics, quality, traceability, phaseState

github-actions · 2026-03-02T03:27:49Z

Generate Artifacts Preview

Generated at: 2026-03-02T05:28:17.803Z

tests/api/generated: clean
artifacts/codex: clean
artifacts/spec: clean

github-actions · 2026-03-02T03:28:01Z

CodeX Artifacts Summary

• Contract/E2E templates: 1 files (dir: tests/api/generated)
• Tests: PBT files=123, BDD features=0
• Formal specs: TLA=1, Alloy=1

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 09c9575fec

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

scripts/ci/lib/review-comment-classifier.mjs

github-actions · 2026-03-02T03:29:12Z

KvOnce Trace Validation

OTLP: ✅ Success (Issues: 0)
NDJSON: ✅ Success (Issues: 0)

Copilot

Pull request overview

非 suggestion のレビュー指摘を自動処理ループに載せるための基盤として、レビューコメント本文のルールベース分類と actionable 指摘の task 化（+ 要約出力）を追加するPRです（#2373 / PR-1 相当）。

Changes:

レビューコメント本文から suggestion ブロックを抽出する処理を追加
本文を suggestion / actionable / informational に分類し、actionable から deterministic な task を生成するコアを追加
上記の単体テスト（抽出/分類/task生成/要約）を追加

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
scripts/ci/lib/review-comment-classifier.mjs	suggestion 抽出・本文分類・actionable task 生成・task 要約のコア実装を追加
tests/unit/ci/review-comment-classifier.test.ts	classifier の主要機能に対する unit test を追加

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

scripts/ci/lib/review-comment-classifier.mjs

tests/unit/ci/review-comment-classifier.test.ts

github-actions · 2026-03-02T03:30:56Z

@artifacts/quality/comment-body.txt

…etadata

github-actions · 2026-03-02T03:42:49Z

❓ Code Generation Drift Detection

Status:
Regeneration needed: No

Automated by AE-Framework Codegen

github-actions · 2026-03-02T03:43:47Z

CodeX Artifacts Summary

• Contract/E2E templates: 1 files (dir: tests/api/generated)
• Tests: PBT files=123, BDD features=0
• Formal specs: TLA=1, Alloy=1

github-actions · 2026-03-02T03:45:43Z

CI Status Snapshot (2026-03-02T05:21:56.225Z)

ci(review): 非 suggestion 指摘の分類・task化コアを追加 #2378 ci(review): 非 suggestion 指摘の分類・task化コアを追加 | ✅40 ❌4 ⏳0 ⏭️49 | review:NONE | mergeable:MERGEABLE
- failed: gate, gate, gate, gate

github-actions · 2026-03-02T03:46:56Z

@artifacts/quality/comment-body.txt

ootakazuhiko · 2026-03-02T03:48:14Z

レビュー本文・インラインコメントを全件確認し、以下を実施しました。

本文レビュー:
- Codex/Copilot本文は概要確認中心で、追加の修正要求はありませんでした。
インラインコメント:
- 5件すべてに返信済み。
- 必要な修正を反映（混在コメントでactionable優先、commentId欠落時fail-closed、line範囲正規化、追加テスト）。
- 返信後に全threadをresolve済み。
CI:
- Copilot Review Gate の過去失敗runを再実行し、required checksがすべてpassであることを確認しました。

追加で確認が必要な点があれば指示ください。

github-actions · 2026-03-02T05:27:28Z

❓ Code Generation Drift Detection

Status:
Regeneration needed: No

Automated by AE-Framework Codegen

github-actions · 2026-03-02T05:28:25Z

CodeX Artifacts Summary

• Contract/E2E templates: 1 files (dir: tests/api/generated)
• Tests: PBT files=123, BDD features=0
• Formal specs: TLA=1, Alloy=1

github-actions · 2026-03-02T05:31:55Z

@artifacts/quality/comment-body.txt

ci(review): add actionable comment classifier and task generator core

09c9575

Copilot AI review requested due to automatic review settings March 2, 2026 03:26

ootakazuhiko mentioned this pull request Mar 2, 2026

[Sub-issue] 非 suggestion レビュー指摘の自動対応ループ実装（Codex連携） #2373

Closed

8 tasks

Copilot started reviewing on behalf of ootakazuhiko March 2, 2026 03:27 View session

github-actions bot added the enforce-testing Make testing DDD scripts strict/blocking label Mar 2, 2026

github-actions bot added the risk:low Low risk PR (auto-merge candidate) label Mar 2, 2026

chatgpt-codex-connector bot reviewed Mar 2, 2026

View reviewed changes

scripts/ci/lib/review-comment-classifier.mjs Outdated Show resolved Hide resolved

Copilot AI reviewed Mar 2, 2026

View reviewed changes

ci(review): prioritize actionable mixed comments and normalize task m…

439a7ff

…etadata

Merge branch 'main' into feat/2373-review-comment-classifier

fa9b45f

ootakazuhiko merged commit dc7a3a4 into main Mar 2, 2026
82 checks passed

ootakazuhiko deleted the feat/2373-review-comment-classifier branch March 2, 2026 05:38

Conversation

ootakazuhiko commented Mar 2, 2026

概要

変更内容

テスト

Uh oh!

github-actions bot commented Mar 2, 2026

❓ Code Generation Drift Detection

Uh oh!

github-actions bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Quality Summary

Harness Health

Change Package

Change Package Validation

Uh oh!

github-actions bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress Summary

Uh oh!

github-actions bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generate Artifacts Preview

Uh oh!

github-actions bot commented Mar 2, 2026

CodeX Artifacts Summary

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

github-actions bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

KvOnce Trace Validation

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

❓ Code Generation Drift Detection

Uh oh!

github-actions bot commented Mar 2, 2026

CodeX Artifacts Summary

Uh oh!

github-actions bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Status Snapshot (2026-03-02T05:21:56.225Z)

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

ootakazuhiko commented Mar 2, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

❓ Code Generation Drift Detection

Uh oh!

github-actions bot commented Mar 2, 2026

CodeX Artifacts Summary

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Mar 2, 2026 •

edited

Loading

github-actions bot commented Mar 2, 2026 •

edited

Loading

github-actions bot commented Mar 2, 2026 •

edited

Loading

github-actions bot commented Mar 2, 2026 •

edited

Loading

github-actions bot commented Mar 2, 2026 •

edited

Loading