Skip to content

display a more verbose error when importing a model #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
privateip merged 1 commit into from
Mar 18, 2025
Merged

display a more verbose error when importing a model #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions internal/runners/models.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,9 @@ func (r *ModelRunner) importActionMap(action map[string]interface{}, path string
if !skipChecks {
wf, err := services.NewWorkflowService(r.client).Get(value.(string))
if err != nil {
return err
return errors.New(
fmt.Sprintf("workflow for action `%s` encountered the following error: %s", action["name"], err.Error()),
)
}
if wf != nil {
return errors.New(
Expand All @@ -551,7 +553,9 @@ func (r *ModelRunner) importActionMap(action map[string]interface{}, path string
var res *services.Transformation
res, err := services.NewTransformationService(r.client).Get(value.(string))
if err != nil {
return err
return errors.New(
fmt.Sprintf("pre transformation for action `%s` encountered the following error: %s", action["name"], err.Error()),
)
}
if res != nil {
return errors.New(
Expand All @@ -577,7 +581,9 @@ func (r *ModelRunner) importActionMap(action map[string]interface{}, path string
var res *services.Transformation
res, err := services.NewTransformationService(r.client).Get(value.(string))
if err != nil {
return err
return errors.New(
fmt.Sprintf("post transformation for action `%s` encountered the following error: %s", action["name"], err.Error()),
)
}
if res != nil {
return errors.New(
Expand All @@ -597,7 +603,6 @@ func (r *ModelRunner) importActionMap(action map[string]interface{}, path string
}
delete(action, "postWorkflowjstFilename")
action["postWorkflowJst"] = res.Id

}

return nil
Expand Down
Loading