fix: --config flag ignored when placed before subcommand#322
Merged
privateip merged 1 commit intoitential:develfrom Mar 4, 2026
Merged
Conversation
The --config global option was added as a parent parser to both the main parser and each subparser. When --config appeared before the subcommand (e.g. `itential-mcp --config file.conf test`), the main parser captured it correctly, but the subparser then overwrote it with its default (None), causing the config file to never be loaded. Removed `parents=[global_options_parser]` from subparsers so --config is only parsed once by the main parser, preventing the overwrite. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
privateip
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
itential-mcp --config file.conf <command>silently ignored the config file, defaulting tolocalhost:443--configwas inherited viaparents=[global_options_parser]on both the main parser and each subparser. When--configappeared before the subcommand, the main parser captured it, but the subparser overwrote it withNone(its default)parents=[global_options_parser]from subparsers so--configis only parsed once by the main parserTest plan
itential-mcp --config file.conf testnow correctly reads the config filetest_parse_args_config_fileto use the correct argument ordering🤖 Generated with Claude Code