fix: make package and description optional on GetAdaptersElement#338
Open
fordjes wants to merge 1 commit intoitential:develfrom
Open
fix: make package and description optional on GetAdaptersElement#338fordjes wants to merge 1 commit intoitential:develfrom
fordjes wants to merge 1 commit intoitential:develfrom
Conversation
…ntial#330) IAP returns null for package and description fields on adapters that are not fully registered. The previous required str fields caused a Pydantic ValidationError on any get_adapters() call when such adapters exist in the platform response. Closes itential#330 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nullforpackageanddescriptionon adapter objects that are not fully registeredstrfields caused a PydanticValidationErroron anyget_adapters()call when such adapters exist in the platform responsestr | None = Noneand added 4 regression testsTest plan
make cipasses on the branchtests/test_models_adapters.pycover null-field scenariosget_adapterstool returns successfully when unregistered adapters are presentFixes #330
🤖 Generated with Claude Code