Merged
Conversation
Nick-Andreano
requested review from
kvelarde-itential and
steven-schattenberg-itential
and removed request for
kvelarde-itential and
steven-schattenberg-itential
kvelarde-itential
requested changes
Jun 17, 2024
| ansible.builtin.fail: | ||
| msg: "missing or invalid iag_release" | ||
| when: iag_release == "UNDEFINED" | ||
| msg: "Deployer installer does not support installing Gateway version {{iag_release}} on {{ ansible_distribution | lower }}-{{ ansible_distribution_major_version }}" |
Contributor
There was a problem hiding this comment.
Suggested change
| msg: "Deployer installer does not support installing Gateway version {{iag_release}} on {{ ansible_distribution | lower }}-{{ ansible_distribution_major_version }}" | |
| msg: "Deployer does not support installing Gateway version {{ iag_release }} on {{ ansible_distribution }} {{ ansible_distribution_major_version }}" |
| msg: "missing or invalid iag_release" | ||
| when: iag_release == "UNDEFINED" | ||
| msg: "Deployer installer does not support installing Gateway version {{iag_release}} on {{ ansible_distribution | lower }}-{{ ansible_distribution_major_version }}" | ||
| when: valid_iag_release is defined |
Contributor
There was a problem hiding this comment.
Suggested change
| when: valid_iag_release is defined | |
| when: invalid_iag_release is defined |
| ansible.builtin.fail: | ||
| msg: "missing or invalid iag_release" | ||
| when: iag_release == "UNDEFINED" | ||
| msg: "Deployer installer does not support installing Gateway version {{iag_release}} on {{ ansible_distribution | lower }}-{{ ansible_distribution_major_version }}" |
Contributor
There was a problem hiding this comment.
Suggested change
| msg: "Deployer installer does not support installing Gateway version {{iag_release}} on {{ ansible_distribution | lower }}-{{ ansible_distribution_major_version }}" | |
| msg: "Deployer does not support installing Gateway version {{ iag_release }} on {{ ansible_distribution }} {{ ansible_distribution_major_version }}" |
| msg: "missing or invalid iag_release" | ||
| when: iag_release == "UNDEFINED" | ||
| msg: "Deployer installer does not support installing Gateway version {{iag_release}} on {{ ansible_distribution | lower }}-{{ ansible_distribution_major_version }}" | ||
| when: valid_iag_release is defined |
Contributor
There was a problem hiding this comment.
Suggested change
| when: valid_iag_release is defined | |
| when: invalid_iag_release is defined |
| # GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt) | ||
| --- | ||
| iag_release: UNDEFINED | ||
| valid_iag_release: false |
Contributor
There was a problem hiding this comment.
Suggested change
| valid_iag_release: false | |
| invalid_iag_release: true |
Comment on lines
+25
to
+26
| msg: "Deployer installer does not support installing Redis on IAP version {{ iap_release }}" | ||
| when: valid_redis_packages is defined |
Contributor
There was a problem hiding this comment.
Suggested change
| msg: "Deployer installer does not support installing Redis on IAP version {{ iap_release }}" | |
| when: valid_redis_packages is defined | |
| msg: "Deployer does not support installing Redis for IAP version {{ iap_release }}" | |
| when: invalid_redis_release is defined |
Comment on lines
+13
to
+14
| msg: "Deployer installer does not support installing Redis on IAP version {{ iap_release }}" | ||
| when: valid_redis_packages is defined |
Contributor
There was a problem hiding this comment.
Suggested change
| msg: "Deployer installer does not support installing Redis on IAP version {{ iap_release }}" | |
| when: valid_redis_packages is defined | |
| msg: "Deployer does not support installing Redis for IAP version {{ iap_release }}" | |
| when: invalid_redis_release is defined |
| # GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt) | ||
| --- | ||
| redis_packages: UNDEFINED | ||
| valid_redis_packages: false |
Contributor
There was a problem hiding this comment.
Suggested change
| valid_redis_packages: false | |
| invalid_redis_release: true |
| msg: "missing or invalid mongodb_release_url" | ||
| when: mongodb_release_url == "UNDEFINED" | ||
| msg: "Deployer installer does not support installing MongoDB for IAP version {{ iap_release }} on {{ ansible_distribution | lower }}-{{ ansible_distribution_major_version }}" | ||
| when: valid_mongodb_version is defined |
Contributor
There was a problem hiding this comment.
Suggested change
| when: valid_mongodb_version is defined | |
| when: invalid_mongodb_release is defined |
Comment on lines
+30
to
+31
| msg: "Deployer installer does not support installing on OS version {{ ansible_distribution_major_version }}!" | ||
| when: valid_release_version is defined |
Contributor
There was a problem hiding this comment.
Suggested change
| msg: "Deployer installer does not support installing on OS version {{ ansible_distribution_major_version }}!" | |
| when: valid_release_version is defined | |
| msg: "Deployer installer does not support installing on {{ ansible_distribution }} {{ ansible_distribution_major_version }}" | |
| when: invalid_os_release is defined |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.