Use urljoin to prevent issue with trailing slash in SMP URL#17
Merged
arj03 merged 1 commit intoiterasdev:masterfrom Dec 9, 2025
Merged
Use urljoin to prevent issue with trailing slash in SMP URL#17arj03 merged 1 commit intoiterasdev:masterfrom
arj03 merged 1 commit intoiterasdev:masterfrom
Conversation
Collaborator
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem observed in production:
I solved it with
urljoinand./. Using/seems dangerous if there are actually subpath-based SMPs and nothing in front failed because urljoin then considersiso6523-actorid-upis::to be an URL scheme`