Add Dev Container configuration#462
Merged
shcheklein merged 2 commits intoiterative:masterfrom May 15, 2023
ludelafo:master
Merged
Add Dev Container configuration#462shcheklein merged 2 commits intoiterative:masterfrom ludelafo:master
shcheklein merged 2 commits intoiterative:masterfrom
ludelafo:master
Conversation
shcheklein
reviewed
May 14, 2023
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "image": "mcr.microsoft.com/vscode/devcontainers/javascript-node:18", | |||
Member
There was a problem hiding this comment.
let's try mcr.microsoft.com/devcontainers/typescript-node:20
shcheklein
reviewed
May 14, 2023
Member
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
Thanks @ludelafo ! Let's also add:
"codespaces": "yarn dev -H 0.0.0.0",
"csps": "yarn dev -H 0.0.0.0",
to the package JSON (we do this in some other projects) to run the website in Codespace and enable access to it. Would be great to see if we need to update docs as well (contrib).
shcheklein
reviewed
May 14, 2023
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "image": "mcr.microsoft.com/vscode/devcontainers/javascript-node:18", | |||
| "postCreateCommand": "yarn" | |||
Member
There was a problem hiding this comment.
Add also:
"customizations": {
"vscode": {
"extensions": [
"redhat.vscode-yaml",
"dbaeumer.vscode-eslint",
"stkb.rewrap",
"streetsidesoftware.code-spell-checker",
"esbenp.prettier-vscode"
]
}
- they are handy when we deal with docs
shcheklein
added
enhancement
shcheklein
approved these changes
May 15, 2023
Member
|
Thanks @ludelafo ! |
Link Check ReportThere were no links to check! |
Contributor
Author
|
You're welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Dev Containers in order to have a quick and easy development environment using Dev Containers.