logger: output footer once for multithreaded push/pull errors #2674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n3hrox
commented
Nov 1, 2019
| # so won't be reused by any other subsequent run anyway. | ||
| clean_repos() | ||
|
|
||
| if ret != 0: |
Author
There was a problem hiding this comment.
not sure if it should be here or rather in finally block
added 2 commits
November 1, 2019 16:38
Suor
suggested changes
Nov 1, 2019
| # so won't be reused by any other subsequent run anyway. | ||
| clean_repos() | ||
|
|
||
| if ret != 0: |
efiop
reviewed
Nov 1, 2019
efiop
reviewed
Nov 1, 2019
n3hrox
commented
Nov 3, 2019
| nc=colorama.Fore.RESET, | ||
| levelname=record.levelname, | ||
| description=self._description(record.msg, exception), | ||
| msg=record.msg, |
Author
There was a problem hiding this comment.
I see that deepsource detected that msg is not used here although I did not delete it
I think adding it back to message or removing it entirely should be scope of another PR to be honest, as it affects multiple test cases.
What do you think @efiop?
Contributor
There was a problem hiding this comment.
You are right, it is out of scope for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you followed the guidelines in our
Contributing document?
Does your PR affect documented changes or does it add new functionality
that should be documented? If yes, have you created a PR for
dvc.org documenting it or at
least opened an issue for it? If so, please add a link to it.
This should fix #2553
There is one test already for
_downloadso it should be sufficient.If you have any suggestions how could I test the footer appearance deduplication with pytest please let me know! This is my first PR for open source repo so any comments are welcome.