Add better heuristic for build detection #2773
Conversation
dvc/updater.py
Outdated
| "formula": "Run {yellow}brew{reset} upgrade dvc", | ||
| "apt": ( | ||
| "rpm": "Run {yellow}yum{reset} update dvc", | ||
| "osxpkg": "Run {yellow}brew{reset} upgrade dvc", |
There was a problem hiding this comment.
osxpkg is not the same as brew formula. We need to add build.py with PKG = 'formula' or PKG = "brew"(this one is even better 🙂 ) to our homebrew formula https://github.com/iterative/homebrew-dvc/blob/master/Formula/dvc.rb (after that we'll submit the same changes to homebrew-core).
There was a problem hiding this comment.
I think we could also echo somewhere there, need to take a closer look.
There was a problem hiding this comment.
I'll include that into our and homebrew-core formulas after this PR is merged.
There was a problem hiding this comment.
For the record: Added iterative/homebrew-dvc@68d0f02 . Will play around with it and then release a new version and submit it to homebrew-core.
dvc/utils/pkg.py
Outdated
|
|
||
|
|
||
| def is_conda(): | ||
| def get_package_manager(): |
There was a problem hiding this comment.
Btw, no good reason to make this dynamic, let's just:
try:
from .build import PKG # file created during dvc build
except ImportError:
PKG = None
and then just import PKG where needed, instead of get_package_manager
There was a problem hiding this comment.
DeepSource shows that as anti-pattern, do you still want to keep without function wrap?
There was a problem hiding this comment.
@n3hrox DS is saying that PKG is unused, which is on purpose here, so we are fine 🙂
efiop
left a comment
efiop
left a comment
There was a problem hiding this comment.
Looks great! 🙂 Just a few minor comments left.
2 participants
❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addresses. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏