Skip to content

Conversation

@skshetry
Copy link
Collaborator

  • ❗ Have you followed the guidelines in the Contributing to DVC list?

  • πŸ“– Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.

  • ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@efiop
Copy link
Contributor

efiop commented Nov 26, 2019

@skshetry Thanks πŸ™ What do you use to find them, btw?

@skshetry
Copy link
Collaborator Author

@efiop, I used "Inspect Code" on Pycharm, but, it checks everything (including variable names).

P.S. Deepsource is failing, even though, I haven't made any changes where it failed.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks πŸ‘

@efiop
Copy link
Contributor

efiop commented Nov 26, 2019

@skshetry Got it, PyCharm is making it tempting for me to try it out again πŸ™‚

About DS, it is triggered on any file you touch, so just ignore it this time.

@efiop efiop merged commit 424931f into treeverse:master Nov 26, 2019
@skshetry skshetry deleted the fix-typo branch November 26, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants