temporary_windows_drive fixture: move to dir_helpers #2937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pared
force-pushed
the
2896_add_windows
branch
from
c721078 to
3234d20
Compare
|
Should not be moved to |
pared
force-pushed
the
2896_add_windows
branch
2 times, most recently
from
9047493 to
1a6eebf
Compare
Suor
suggested changes
Dec 11, 2019
Suor
suggested changes
Dec 13, 2019
tests/func/test_add.py
Outdated
There was a problem hiding this comment.
-> tmp_path_factory
This aimed to replace tmpdir_factory, they have the migration of their own in pytest http://doc.pytest.org/en/latest/tmpdir.html#the-tmp-path-factory-fixture
|
@pared ? |
pared
force-pushed
the
2896_add_windows
branch
from
1a6eebf to
d40588a
Compare
Suor
reviewed
Dec 16, 2019
| ret = main(["config", "cache.dir", temporary_windows_drive]) | ||
| assert ret == 0 | ||
| dvc.config.set("cache", "dir", temporary_windows_drive) | ||
| dvc.cache = Cache(dvc) |
There was a problem hiding this comment.
Cool, still hacky. We might fix this, but since we only need this in tests, it is not worth the effort.
Suor
approved these changes
Dec 16, 2019
efiop
approved these changes
Dec 16, 2019
efiop
added
refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏