Skip to content

dvc: make graph consist of stages not their paths #3012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 30, 2019
Merged

dvc: make graph consist of stages not their paths #3012

merged 2 commits into from
Dec 30, 2019

Conversation

@Suor
Copy link
Contributor

@Suor Suor commented Dec 28, 2019

No description provided.

shcheklein
shcheklein reviewed Dec 28, 2019
View reviewed changes
shcheklein
shcheklein reviewed Dec 28, 2019
View reviewed changes
shcheklein
shcheklein approved these changes Dec 28, 2019
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor questions

efiop
efiop approved these changes Dec 28, 2019
View reviewed changes
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! 🔥

@weekly-digest weekly-digest bot mentioned this pull request Dec 29, 2019
Closed
@Suor
Copy link
Contributor Author

Suor commented Dec 30, 2019

Removed a TODO, changed repo comparison to is.

@shcheklein
Copy link
Member

@Suor thanks 🙏

@efiop efiop merged commit 0a3a9bf into iterative:master Dec 30, 2019
@efiop efiop added the refactoring Factoring and re-factoring label Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shcheklein shcheklein shcheklein approved these changes

+1 more reviewer

@efiop efiop efiop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Suor Suor

Labels

refactoring Factoring and re-factoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Suor @shcheklein @efiop