conftest: remove dvc_repo, erepo, git, git_erepo #3142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pared
force-pushed
the
remove_fixtures
branch
from
3160e00 to
50f3408
Compare
|
@pared , tests are failing, but looks good so far) |
pared
force-pushed
the
remove_fixtures
branch
from
50f3408 to
59350c0
Compare
pared
force-pushed
the
remove_fixtures
branch
from
59350c0 to
1844699
Compare
pared
commented
Jan 16, 2020
|
|
||
| import mockssh | ||
| import pytest | ||
| from git import Repo |
Contributor
Author
There was a problem hiding this comment.
For some reason, removing this import causes test_get_from_non_dvc_master to fail, hence additional caplog.at_level there. I was unable to invesitage it in reasonable amount of time, so leaving this comment and creating issue.
efiop
added
p1-important
efiop
approved these changes
Jan 16, 2020
skshetry
reviewed
Jan 16, 2020
pared
force-pushed
the
remove_fixtures
branch
from
3d8780b to
36c64c6
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏