Import in conftest disables logging for a package logger

[pared]

As mentioned in comment under #3142:
if import git is included up to next line after import pytest in conftest.py The loggers originating in git seems to be disabled during tests.

@pared , not sure I follow. I ran the test after adding this patch and it worked for me. Is it correct?

diff --git a/tests/conftest.py b/tests/conftest.py
index 6e01739a..28e87efd 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -2,6 +2,7 @@ import os
 
 import mockssh
 import pytest
+import git
 
 from dvc.remote.ssh.connection import SSHConnection
 from .dir_helpers import *  # noqa

[pared]

@MrOutis, try that one:

diff --git a/tests/func/test_get.py b/tests/func/test_get.py
index 87d8ceea..7bffd0a2 100644
--- a/tests/func/test_get.py
+++ b/tests/func/test_get.py
@@ -178,7 +178,7 @@ def test_get_from_non_dvc_master(tmp_dir, erepo_dir, caplog):
 
     # removing `git` import in conftest resulted in unexpected logs from
     # that package, see https://github.com/iterative/dvc/issues/3167
-    with caplog.at_level(logging.INFO, logger="git"), caplog.at_level(
+    with caplog.at_level(
         logging.INFO, logger="dvc"
     ):
         Repo.get(fspath(erepo_dir), "some_file", out=dst, rev="branch")

[pared]

With your change test_get_from_non_dvc_master will pass, without it, it will not.

[efiop]

Yet another occurence in https://travis-ci.com/iterative/dvc/jobs/284360662#L3097 for #3284 . Using that workaround in conftest now.

[efiop]

stale