Skip to content

Conversation

@skshetry
Copy link
Collaborator

  • ❗ Have you followed the guidelines in the Contributing to DVC list?

  • πŸ“– Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.

  • ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@skshetry skshetry added the refactoring Factoring and re-factoring label Jan 20, 2020
@skshetry skshetry requested a review from a user January 20, 2020 16:05
@skshetry skshetry self-assigned this Jan 20, 2020
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, @skshetry ⚑

@skshetry skshetry requested a review from efiop January 20, 2020 17:01
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks!

@efiop efiop merged commit 39bf7c0 into iterative:master Jan 20, 2020
@skshetry skshetry deleted the remove-use-six branch January 20, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Factoring and re-factoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants