Skip to content

Conversation

@pared
Copy link
Contributor

@pared pared commented Jan 24, 2020

  • ❗ Have you followed the guidelines in the Contributing to DVC list?

  • πŸ“– Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.

  • ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Found one wrong link in code, added link formating for some more man.dvc.org usages.

dvc/dagascii.py Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

man.dvc.org unrolls to https://dvc.org/doc/command-reference/ so we would get 404 here

@pared pared requested a review from efiop January 24, 2020 10:37
@pared
Copy link
Contributor Author

pared commented Jan 24, 2020

Turns out that links without https:// ar not clicable in terminal, need to fix that.

Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@efiop efiop merged commit a65b6c7 into iterative:master Jan 24, 2020
@efiop efiop added enhancement Enhances DVC ui user interface / interaction labels Jan 24, 2020
@pared pared deleted the link_fixes branch March 24, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhances DVC ui user interface / interaction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants