Skip to content

Conversation

@dmpetrov
Copy link
Contributor

@dmpetrov dmpetrov commented Jan 26, 2020

An iteration on summoning (see https://github.com/iterative/dvcx/pull/4):

  1. Some minor Summon file format changes and default file name change to Summon.yaml.
  2. Separating reading objects and pulling data. It is needed for flexibility and especially for data objects with several files like a compound CSV file (see in api: high level dvc.api import/export meets data catalog #2719).
  3. Summon object update update_dobj(). This is not completed but it does not break current read-only logic.
  4. Moving part of the logic to SummonDesc class.
  • ❗ Have you followed the guidelines in the Contributing to DVC list?

  • 📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.

  • ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@dmpetrov dmpetrov requested a review from Suor January 26, 2020 11:17
@dmpetrov
Copy link
Contributor Author

dmpetrov commented Feb 2, 2020

@Suor should we close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants