Fix repro duplicating effort while checking steps #3644 #3645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
To close #3644 |
Closed
Contributor
|
Hi @charlesbaynham ! Thanks a lot for the PR! Please make sure to install our pre-commit hooks as per contribution guide. They will check for styling and some lint issues. |
charlesbaynham
force-pushed
the
fix-repro
branch
from
ca61128 to
d193c92
Compare
Contributor
Author
Don't worry, I will before I resolve the WIP! |
charlesbaynham
changed the title
charlesbaynham
force-pushed
the
fix-repro
branch
from
d193c92 to
f5d89f6
Compare
charlesbaynham
changed the title
Contributor
Author
|
Ok dokey, that's ready for review @efiop I assume all the commits get squashed on merge. If not, let me know and I'll squash them. |
efiop
reviewed
Apr 20, 2020
Contributor
|
So sorry for the delay! Please see a comment above |
charlesbaynham
force-pushed
the
fix-repro
branch
from
cde4cf4 to
06a1a96
Compare
efiop
approved these changes
Apr 21, 2020
Contributor
efiop
left a comment
efiop
left a comment
There was a problem hiding this comment.
Thank you @charlesbaynham ! 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏