Skip to content

Conversation

@pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Apr 24, 2020

  • ❗ I have followed the Contributing to DVC checklist.

  • πŸ“– If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Fixes errors from latest flake8 master (pycodestyle >= 2.6.0a1, < 2.7.0)

[INFO] This may take a few minutes...
black....................................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1
tests/func/test_repro.py:1558:39: E741 ambiguous variable name 'l'
dvc/dagascii.py:98:41: E741 ambiguous variable name 'l'
beautysh.................................................................Passed
DVC pre-commit...........................................................Passed
- hook id: dvc-pre-commit
- duration: 16.59s

@pmrowla pmrowla added the refactoring Factoring and re-factoring label Apr 24, 2020
@pmrowla pmrowla self-assigned this Apr 24, 2020
@pmrowla pmrowla merged commit 7e9ff62 into treeverse:master Apr 24, 2020
@pmrowla pmrowla deleted the flake8 branch April 24, 2020 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Factoring and re-factoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant