Skip to content

progress: add postfix info to avoid overwriting desc #3721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 2, 2020
Merged

progress: add postfix info to avoid overwriting desc #3721

merged 3 commits into from
May 2, 2020

Conversation

@casperdcl
Copy link
Contributor

@casperdcl casperdcl commented May 1, 2020 •
edited by efiop
Loading

  • persist desc so as not to confuse users about the operation
  • put info message updates into the postfix
  • fix everything that breaks because of this change
  • discuss git progress
    • was (top recording): Cloning: [elapsed<remaining] => Receiving: | MBps [elapsed<remaining] => Receiving: [elapsed]
    • could be (lower recording): Cloning: [elapsed<remaining] => Cloning: | Receiving | MBps [elapsed<remaining] => Cloning: [elapsed]
  • fixes progress: append to desc #3681

much asciinema such rec

much asciinema such rec

casperdcl added 2 commits May 1, 2020 23:42
@casperdcl
progress: persist primary description
f8ac0d5 
Move subsequent updates to a postfix.
Clear postfix on exit.
TODO: align nicely.
Fixes treeverse#3681.
@casperdcl
progress: move to posfix[info] for full control
4746b8c 
It was bound to happen.
@casperdcl casperdcl added enhancement Enhances DVC refactoring Factoring and re-factoring ui user interface / interaction discussion requires active participation to reach a conclusion labels May 1, 2020
@casperdcl casperdcl requested review from efiop and shcheklein May 1, 2020 23:57
@casperdcl casperdcl self-assigned this May 1, 2020
@casperdcl casperdcl changed the title Progress sub progress: add postfix info to avoid overwriting desc May 2, 2020
@efiop efiop merged commit c873787 into treeverse:master May 2, 2020
@weekly-digest weekly-digest bot mentioned this pull request May 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shcheklein shcheklein Awaiting requested review from shcheklein

1 more reviewer

@efiop efiop efiop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@casperdcl casperdcl

Labels

discussion requires active participation to reach a conclusion enhancement Enhances DVC refactoring Factoring and re-factoring ui user interface / interaction

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

progress: append to desc

2 participants

@casperdcl @efiop