update: --recursive flag #3760
Merged
update: --recursive flag #3760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
reviewed
May 8, 2020
efiop
reviewed
May 8, 2020
dvc/repo/update.py
Outdated
| stages = self.collect(targets, recursive=recursive) | ||
| else: | ||
| stages = set() | ||
| for target in targets: |
Contributor
There was a problem hiding this comment.
Could also
if isinstance(targets, str):
targets = [targets]
just as a convenience (we have that in dvc add too), since it is guaranteed someone will try to misuse it 🙂
Contributor
Author
There was a problem hiding this comment.
By the way are the any other commands which should contain isinstance(targets, str) check? repo.used_cache, repo.status, repo._checkout seem good candidates.
Contributor
There was a problem hiding this comment.
@nik123 Probably not used_cache but the rest could use it, sure. But let's not bother with it in this PR, it is out of scope 🙂
efiop
approved these changes
May 8, 2020
Contributor
|
Thanks @nik123 ! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3511
See treeverse/dvc.org#1259