Skip to content

Conversation

@skshetry
Copy link
Collaborator

@skshetry skshetry commented Jul 2, 2020

  • ❗ I have followed the Contributing to DVC checklist.

  • πŸ“– If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@skshetry skshetry self-assigned this Jul 2, 2020
@skshetry
Copy link
Collaborator Author

skshetry commented Jul 3, 2020

pytest and pytest tests/func/test_ls.py passes all tests, pytest tests/func/test_{get,import,ls}.py fails. πŸ˜•

@skshetry
Copy link
Collaborator Author

skshetry commented Jul 3, 2020

Closing for now, discussed with @efiop to go for a better abstraction here.

@skshetry skshetry closed this Jul 3, 2020
@skshetry skshetry deleted the subrepo-get-import branch July 3, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant