Skip to content

Conversation

@efiop
Copy link
Contributor

@efiop efiop commented Jul 3, 2020

Usually we need it to parametrize tests with, so there is no
reason to duplicate the code. I've left local_remote fixture
just because it is so convenient and often used in a lot of tests.

  • ❗ I have followed the Contributing to DVC checklist.

  • 📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Usually we need it to parametrize tests with, so there is no
reason to duplicate the code. I've left `local_remote` fixture
just because it is so convenient and often used in a lot of tests.
@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #4163 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4163   +/-   ##
=======================================
  Coverage   92.61%   92.61%           
=======================================
  Files         162      162           
  Lines       11304    11304           
=======================================
  Hits        10469    10469           
  Misses        835      835           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dd264c...178a431. Read the comment docs.

@efiop efiop merged commit 30212f8 into master Jul 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the remote-fixture branch July 3, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant