Skip to content

Conversation

@efiop
Copy link
Contributor

@efiop efiop commented Jul 7, 2020

Previous implementation didn't take into account that 2nd and 3rd level commands might have the same name, so we can't use it to identify a proper parser. Now we use cmd class instead, which is reliable.

Fixes #4043

  • ❗ I have followed the Contributing to DVC checklist.

  • 📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@efiop efiop force-pushed the fix-4043 branch 2 times, most recently from 99a3082 to 329789f Compare July 7, 2020 02:53
@efiop efiop merged commit 8964967 into iterative:master Jul 7, 2020
@efiop efiop deleted the fix-4043 branch July 7, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect help message on wrong flags for metrics and plots

1 participant