Skip to content

Conversation

@efiop
Copy link
Contributor

@efiop efiop commented Jul 14, 2020

No longer needed, all tests are using mocked ssh already.

  • ❗ I have followed the Contributing to DVC checklist.

  • πŸ“– If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

No longer needed, all tests are using mocked ssh already.
@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #4200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4200   +/-   ##
=======================================
  Coverage   92.61%   92.61%           
=======================================
  Files         162      162           
  Lines       11332    11332           
=======================================
  Hits        10495    10495           
  Misses        837      837           

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 1c9588e...42e5853. Read the comment docs.

@efiop efiop merged commit 4c9245a into master Jul 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the test_remove_ssh branch July 14, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant