Skip to content

repro: update status message for dvc-added files #4317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2020
Merged

repro: update status message for dvc-added files #4317

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64b996e
stage/__init__.py: Updated output for dvc repro
sarthakforwet Aug 2, 2020
c588e2c
Delete config.ini
efiop Aug 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion dvc/stage/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,12 @@ def remove(self, force=False, remove_outs=True, purge=True):
@rwlocked(read=["deps"], write=["outs"])
def reproduce(self, interactive=False, **kwargs):
if not (kwargs.get("force", False) or self.changed()):
logger.info("Stage '%s' didn't change, skipping", self.addressing)
if not isinstance(self, PipelineStage) and self.is_data_source:
logger.info("'%s' didn't change, skipping", self.addressing)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not this be foo didn't change rather foo.dvc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the same @skshetry but changed my mind on the argument that as .dvc files maintain the updates in the original files hence mentioning foo.dvc rather than foo sounded logical to me.

Also .dvc files are kind of representatives of the original files so using them in the place of original ones should be good IMHO.

else:
logger.info(
"Stage '%s' didn't change, skipping", self.addressing
)
return None

msg = (
Expand Down