repro: update status message for dvc-added files #4317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
For the record: all occurences of this message in the docs are for stages, so no need to adjust anything there. |
skshetry
reviewed
Aug 6, 2020
| if not (kwargs.get("force", False) or self.changed()): | ||
| logger.info("Stage '%s' didn't change, skipping", self.addressing) | ||
| if not isinstance(self, PipelineStage) and self.is_data_source: | ||
| logger.info("'%s' didn't change, skipping", self.addressing) |
There was a problem hiding this comment.
Should not this be foo didn't change rather foo.dvc?
There was a problem hiding this comment.
I thought the same @skshetry but changed my mind on the argument that as .dvc files maintain the updates in the original files hence mentioning foo.dvc rather than foo sounded logical to me.
Also .dvc files are kind of representatives of the original files so using them in the place of original ones should be good IMHO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
It is same PR as #4269.