push: do not push .dir file for directory with missing files #4353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pared
suggested changes
Aug 7, 2020
| name, | ||
| ) | ||
| break | ||
| else: |
Contributor
There was a problem hiding this comment.
shouldn't else be intended to match the if?
Contributor
Author
There was a problem hiding this comment.
it's intended to be for ... else ..., if we get through the list of missing files and none of them belong to the current directory, then we hit the else case and queue the .dir file upload
pared
approved these changes
Aug 7, 2020
efiop
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Fixes #4343.
If a directory has files missing in both local cache and on the remote, we should still try to push the files we have locally, but should not push the
.dirfile. Otherwise, index will think the full directory is present in the remote after the partial push.