Skip to content

Conversation

@dberenbaum
Copy link

Adds lightning param logging, which requires user setup like:

class MyLightningModule(LightningModule):
    def __init__(self, myparam):
        self.save_hyperparameters()

This is the lightning way 🤷 (see https://forums.pytorchlightning.ai/t/how-to-save-hparams-when-not-provided-as-argument-apparently-assigning-to-hparams-is-not-recomended/339/3)

@dberenbaum dberenbaum requested a review from daavoo December 5, 2022 21:05
@daavoo daavoo enabled auto-merge (squash) December 7, 2022 14:37
@daavoo daavoo merged commit 54f6b46 into main Dec 7, 2022
@daavoo daavoo deleted the lightning-params branch December 7, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants