Skip to content

lightning: log params #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 7, 2022
Merged

lightning: log params #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4d803f
lightning: log params
Dec 5, 2022
e58f50e
lightning: clean params for logging
Dec 6, 2022
068128b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/dvclive/lightning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

from pytorch_lightning.loggers.logger import Logger, rank_zero_experiment
from pytorch_lightning.utilities import rank_zero_only
from pytorch_lightning.utilities.logger import (
_convert_params,
_sanitize_callable_params,
_sanitize_params,
)
from torch import is_tensor

from dvclive import Live
Expand Down Expand Up @@ -39,7 +44,10 @@ def name(self):

@rank_zero_only
def log_hyperparams(self, params, *args, **kwargs):
pass
params = _convert_params(params)
params = _sanitize_callable_params(params)
params = _sanitize_params(params)
self.experiment.log_params(params)

@property # type: ignore
@rank_zero_experiment
Expand Down
13 changes: 10 additions & 3 deletions tests/test_lightning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

from dvclive.lightning import DVCLiveLogger
from dvclive.plots.metric import Metric
from dvclive.serialize import load_yaml
from dvclive.utils import parse_metrics

# pylint: disable=redefined-outer-name, unused-argument
Expand All @@ -30,11 +31,13 @@ def __len__(self):


class LitXOR(LightningModule):
def __init__(self):
def __init__(self, latent_dims=4):
super().__init__()

self.layer_1 = nn.Linear(2, 4)
self.layer_2 = nn.Linear(4, 2)
self.save_hyperparameters()

self.layer_1 = nn.Linear(2, latent_dims)
self.layer_2 = nn.Linear(latent_dims, 2)

def forward(self, *args, **kwargs):
x = args[0]
Expand Down Expand Up @@ -113,6 +116,10 @@ def test_lightning_integration(tmp_dir, mocker):
assert os.path.join(scalars, "train", "step", "loss.tsv") in logs
assert os.path.join(scalars, "epoch.tsv") in logs

params_file = dvclive_logger.experiment.params_file
assert os.path.exists(params_file)
assert load_yaml(params_file) == {"latent_dims": 4}


def test_lightning_default_dir(tmp_dir):
model = LitXOR()
Expand Down