Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

Conversation

@mike0sv
Copy link
Contributor

@mike0sv mike0sv commented Mar 16, 2023

Adds --force flag to deploy cli command. If deployment parameters changed and this flag set, mlem will remove old deployment and create new one.
Also, now there will be no error if parameters changed, but old app does not have state

Limitations:

  • for now only available from cli since adding this to API required a bit of refactoring
  • deployment will always be re-created even if platform allows to just update old deployment

related #463
closes #549

@mike0sv mike0sv requested a review from a team March 16, 2023 18:02
@mike0sv mike0sv temporarily deployed to internal March 16, 2023 18:02 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 69.23% and project coverage change: -0.03 ⚠️

Comparison is base (3bc673e) 85.97% compared to head (c3bd179) 85.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
- Coverage   85.97%   85.94%   -0.03%     
==========================================
  Files         107      107              
  Lines        9770     9779       +9     
==========================================
+ Hits         8400     8405       +5     
- Misses       1370     1374       +4     
Impacted Files Coverage Δ
mlem/cli/deployment.py 87.50% <50.00%> (-4.40%) ⬇️
mlem/contrib/sklearn.py 85.24% <100.00%> (ø)
mlem/core/objects.py 87.38% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@aguschin aguschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mike0sv! I assume this is good to be merged, any subsequent work (if any) will be in next PRs?

@omesser
Copy link
Contributor

omesser commented Mar 19, 2023

Can this be merged? 👀

@omesser omesser added ux Things that matter for user experience cli MLEM command-line interface deploy Related to model deployment labels Mar 19, 2023
@aguschin aguschin merged commit 6bf8f12 into main Mar 20, 2023
@aguschin aguschin deleted the feature/force-deploy branch March 20, 2023 08:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cli MLEM command-line interface deploy Related to model deployment ux Things that matter for user experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changing parameters of deployment isn't allowed

4 participants