Skip to content

Conversation

@mattseddon
Copy link
Contributor

@mattseddon mattseddon commented Sep 28, 2022

This PR stabilises our e2e test suite.

Note: We may be kicking the can down the road as insiders will become the stable version shortly.

{
browserName: 'vscode',
browserVersion: 'insiders',
browserVersion: 'stable',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something has happened in insiders which means you cannot focus the plots webview after the experiments webview has been opened. I am still looking into it but this should get everything moving again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is only for the test suite and webdriverio, there is no loss of functionality with insiders.

@mattseddon mattseddon marked this pull request as ready for review September 29, 2022 04:57
@mattseddon mattseddon enabled auto-merge (squash) September 29, 2022 05:00
@mattseddon mattseddon changed the title Remove experiments from previous commits in e2e tests Stabilize e2e tests Sep 29, 2022
await waitForViewContainerToLoad()
const workbench = await browser.getWorkbench()
await workbench.executeCommand('DVC: Garbage Collect Experiments')
await browser.keys('Enter')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[F] This removes experiments that are found against previous commits. It is very likely that they will be missing from the remote so plots diff will fail to load the data.

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 0fcc10e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.9% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 625f719 into main Sep 29, 2022
@mattseddon mattseddon deleted the remove-previous-commit-exp branch September 29, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants