-
Notifications
You must be signed in to change notification settings - Fork 28
Stabilize e2e tests #2493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize e2e tests #2493
Conversation
| { | ||
| browserName: 'vscode', | ||
| browserVersion: 'insiders', | ||
| browserVersion: 'stable', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something has happened in insiders which means you cannot focus the plots webview after the experiments webview has been opened. I am still looking into it but this should get everything moving again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is only for the test suite and webdriverio, there is no loss of functionality with insiders.
| await waitForViewContainerToLoad() | ||
| const workbench = await browser.getWorkbench() | ||
| await workbench.executeCommand('DVC: Garbage Collect Experiments') | ||
| await browser.keys('Enter') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[F] This removes experiments that are found against previous commits. It is very likely that they will be missing from the remote so plots diff will fail to load the data.
|
Code Climate has analyzed commit 0fcc10e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.9% (0.0% change). View more on Code Climate. |
This PR stabilises our e2e test suite.
Note: We may be kicking the can down the road as insiders will become the stable version shortly.