Skip to content

Stabilize e2e tests #2493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 29, 2022
Merged

Stabilize e2e tests #2493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76eadb8
remove experiments from previous commit
mattseddon Sep 28, 2022
f16537c
switch to stable release of VS Code
mattseddon Sep 29, 2022
deb3ad0
Merge branch 'main' into remove-previous-commit-exp
mattseddon Sep 29, 2022
0fcc10e
Merge branch 'main' into remove-previous-commit-exp
mattseddon Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions extension/src/test/e2e/extension.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ suite('DVC Extension For Visual Studio Code', () => {
before('should finish loading the extension', async function () {
this.timeout(240000)
await waitForViewContainerToLoad()
const workbench = await browser.getWorkbench()
await workbench.executeCommand('DVC: Garbage Collect Experiments')
await browser.keys('Enter')
Copy link
Contributor Author

@mattseddon mattseddon Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[F] This removes experiments that are found against previous commits. It is very likely that they will be missing from the remote so plots diff will fail to load the data.

return dismissAllNotifications()
})

Expand Down
2 changes: 1 addition & 1 deletion extension/src/test/e2e/wdio.conf.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const config: Options.Testrunner = {
capabilities: [
{
browserName: 'vscode',
browserVersion: 'insiders',
browserVersion: 'stable',
Copy link
Contributor Author

@mattseddon mattseddon Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something has happened in insiders which means you cannot focus the plots webview after the experiments webview has been opened. I am still looking into it but this should get everything moving again.

Copy link
Contributor Author

@mattseddon mattseddon Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is only for the test suite and webdriverio, there is no loss of functionality with insiders.

'wdio:vscodeOptions': {
extensionPath,
userSettings: {
Expand Down