Fix argument order. Add named arguments. #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfiaudrin-epsyl
approved these changes
Jan 15, 2026
olivhoenen
approved these changes
Jan 20, 2026
| occurrence=uri_obj.occurrence, | ||
| downsampling_method=downsampling_method, | ||
| downsampled_size=downsampled_size, | ||
| range=range |
Contributor
There was a problem hiding this comment.
Ok, but please note that range is not documented in either https://github.com/iterorganization/IBEX/blob/develop/backend/ibex/data_source/data_source_interface.py#L67 or https://github.com/iterorganization/IBEX/blob/develop/backend/ibex/data_source/imas_python_source.py#L386
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed wrong argument order when calling
ibex.imas_python_source.get_data()It caused downsampling to be omitted even when it shouldn't.
Also added arguments names in calls to avoid similar issue in the future.