Include metadata variables for (arrays of) structures in to_xarray#112
Open
maarten-ic wants to merge 2 commits intoiterorganization:developfrom
Open
Include metadata variables for (arrays of) structures in to_xarray#112maarten-ic wants to merge 2 commits intoiterorganization:developfrom
to_xarray#112maarten-ic wants to merge 2 commits intoiterorganization:developfrom
Conversation
More readable code, and less repetition: ```python # before self.ncmeta.get_dimensions(..., self.homogeneous_time) # after self.get_dimensions(...) ```
This allows reading back data in the following scenario:
```python
ids = imas.IDSFactory().core_profiles()
... # fill IDS
xrds = imas.util.to_xarray(ids)
xrds.to_netcdf("data.nc", group="core_profiles/0")
with imas.DBEntry("data.nc", "r") as entry:
ids2 = entry.get("core_profiles")
```
N.B. `to_xarray()` doesn't include metadata for inhomogeneously sized arrays of structures, so the two IDSs in above example could be different.
maarten-ic
requested review from
olivhoenen and
prasad-sawantdesai
as code owners
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows reading back data in the following scenario:
N.B.
to_xarray()doesn't include metadata for inhomogeneously sized arrays of structures, so the two IDSs in above example could be different.