Feature/to_xarray #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows reuse of functionality to (partially) convert IDSs to xarray Datasets.
Reuses most of the tensorization and metadata logic from the netCDF export.
maarten-ic
requested review from
Simon-McIntosh,
olivhoenen and
prasad-sawantdesai
Simon-McIntosh
approved these changes
Mar 12, 2025
Simon-McIntosh
approved these changes
Mar 12, 2025
olivhoenen
requested changes
Mar 13, 2025
Collaborator
olivhoenen
left a comment
olivhoenen
left a comment
There was a problem hiding this comment.
Works well!
But a minor improvement of the docstring would help the users IMO.
olivhoenen
approved these changes
Mar 13, 2025
| In this lesson you will create a ``DataArray`` manually. In a future version of | ||
| IMAS-Python we plan to include functionality that will automatically do this for you. | ||
| That should further simplify working with data inside IDSs. | ||
| This lesson was written before :py:func:`imas.util.to_xarray` was |
Collaborator
There was a problem hiding this comment.
Is there still value in keeping this lesson if it's completely superceded by the new capabilities introduced by this PR?
Collaborator
Author
There was a problem hiding this comment.
Some of the examples can still be useful for people, so I would not remove it: there's some practical use cases for accessing IDS metadata, and some examples for working with IMAS data in Xarray Datasets.
SimonPinches
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request adds the functionality to directly convert (part of) an IDS to an Xarray
Dataset:imas.util.to_xarray.