Skip to content

Conversation

@maarten-ic
Copy link
Collaborator

Remove logic for building the Data Dictionary.

The Data Dictionary definitions are now provided by the imas-data-dictionaries package.

The Data Dictionary definitions are now provided by the `imas-data-dictionaries` package.
@SimonPinches
Copy link
Collaborator

SimonPinches commented Jun 6, 2025

So what happens when there's a new release of the DD? Is IMAS-Python no longer capable of dynamically updating itself or was this never possible and the only way is to make a new installation of IMAS-Python?
(I'm thinking about the versions of IMAS-Python centrally installed as environment modules and which are typically never updated once they go into production).

@olivhoenen
Copy link
Collaborator

So what happens when there's a new release of the DD? Is IMAS-Python no longer capable of dynamically updating itself or was this never possible and the only way is to make a new installation of IMAS-Python? (I'm thinking about the versions of IMAS-Python centrally installed as environment modules and which are typically never updated once they go into production).

https://github.com/iterorganization/IMAS-Python/blob/319a2f698c8c905530274e238ba46a37f6c4e261/docs/source/multi-dd.rst#data-dictionary-definitions
--> we will need to check if that can take precedence over a centrally installed / pointed by PYTHONPATH package...

@maarten-ic
Copy link
Collaborator Author

Is IMAS-Python no longer capable of dynamically updating itself

It never was, you always had to reinstall IMAS-Python to get updated DD definitions. When DD 4.1 will be released, the current IMAS-Python modules will also not contain these updated definitions (unless you rebuild the module).

The main goal of the IMAS-Data-Dictionaries was to make it possible to update the DD definitions independent of the IMAS-Python package version.

I'm thinking about the versions of IMAS-Python centrally installed as environment modules and which are typically never updated once they go into production

Shouldn't IMAS-Data-Dictionaries be a separate env module which can be updated independently of IMAS-Python?
When a new release of the DD and accompanying IMAS-Data-Dictionaries is made, users can load the newer module and keep the same IMAS-Python module?

@maarten-ic maarten-ic marked this pull request as ready for review June 10, 2025 07:47
@SimonPinches
Copy link
Collaborator

Shouldn't IMAS-Data-Dictionaries be a separate env module which can be updated independently of IMAS-Python?
When a new release of the DD and accompanying IMAS-Data-Dictionaries is made, users can load the newer module and keep the same IMAS-Python module?

We were thinking of packaging IMAS-Data-Dictionaries as part of IMAS-Python but having a separate module (in addition) may allow a route to updating the DD versions available at run time. To be tested...

Copy link
Collaborator

@olivhoenen olivhoenen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Let's try that way first, looks neat with pypi install, then we can figure out a way which works for us with EB.

@olivhoenen olivhoenen merged commit da8b1a6 into iterorganization:develop Jun 10, 2025
10 checks passed
@maarten-ic maarten-ic deleted the feature/imas-data-dictionaries branch June 10, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants