restructure header navigation#145
Merged
ioan-alexandra merged 10 commits intoiterorganization:developfrom May 4, 2026
Merged
Conversation
ioan-alexandra
requested review from
MireilleSchneider,
SBlokhuizen and
maarten-ic
as code owners
maarten-ic
reviewed
Apr 20, 2026
Collaborator
maarten-ic
left a comment
maarten-ic
left a comment
There was a problem hiding this comment.
Hi Alexandra,
Amount of custom CSS / JS seems fine for now. Couple of comments though, let me know if anything's unclear!
- If we don't want to show the sidebar at all when we're in the shape editor, could we instead not use it and move its content into a
Row(sidebar, waveform)in the main content area? - Would be nice if the nav switcher showed which component is active:
- Does panel provide an easy option to load the CSS from a file? That would be cleaner than having it in a string literal in the code.
maarten-ic
reviewed
Apr 28, 2026
Collaborator
maarten-ic
left a comment
maarten-ic
left a comment
There was a problem hiding this comment.
Couple of comments, but note that I didn't run the application 😉
Let me know if anything's unclear!
Collaborator
Author
i added some screenshots so it's easier for you and sebbe to review 👍. will refactor what you mentioned |
SBlokhuizen
reviewed
Apr 29, 2026
maarten-ic
reviewed
May 4, 2026
maarten-ic
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #147
@maarten-ic im not sure how much custom css/js code we want for this redesign, let me know if this is overdoing. i will need to rethink some design choices