Skip to content

Replace coil current sliders by tabulator#161

Merged
SBlokhuizen merged 8 commits into
developfrom
ux/coil-currents-table
May 21, 2026
Merged

Replace coil current sliders by tabulator#161
SBlokhuizen merged 8 commits into
developfrom
ux/coil-currents-table

Conversation

@SBlokhuizen
Copy link
Copy Markdown
Collaborator

@SBlokhuizen SBlokhuizen commented May 7, 2026

fixes #151
image

@SBlokhuizen SBlokhuizen requested a review from ioan-alexandra May 7, 2026 11:47
Comment thread waveform_editor/gui/shape_editor/coil_currents.py
Comment thread waveform_editor/gui/shape_editor/coil_currents.py
Comment thread waveform_editor/gui/shape_editor/coil_currents.py Outdated
Comment thread waveform_editor/gui/shape_editor/coil_currents.py
@SBlokhuizen SBlokhuizen marked this pull request as ready for review May 20, 2026 07:55
Copy link
Copy Markdown
Collaborator

@maarten-ic maarten-ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Some small comments below, let me know if you want to discuss anything

Comment thread waveform_editor/gui/shape_editor/coil_currents.py Outdated
Comment thread waveform_editor/gui/shape_editor/coil_currents.py Outdated
Comment thread waveform_editor/gui/shape_editor/coil_currents.py Outdated
Comment thread waveform_editor/gui/shape_editor/coil_currents.py
@SBlokhuizen SBlokhuizen requested a review from maarten-ic May 21, 2026 09:48
Copy link
Copy Markdown
Collaborator

@maarten-ic maarten-ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SBlokhuizen SBlokhuizen merged commit 52b33b6 into develop May 21, 2026
7 checks passed
@SBlokhuizen SBlokhuizen deleted the ux/coil-currents-table branch May 21, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move from sliders to table for the Coils tab

3 participants