Skip to content

Fix error when resume download on iOS #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2020
Merged

Fix error when resume download on iOS #854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c1eaea
Fix evaluating undefined 'res.jobId'
ouabing Feb 20, 2020
f885f97
Fix typo in JS
ouabing Feb 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion FS.common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ var RNFS = {

if (options.resumable) {
subscriptions.push(RNFS_NativeEventEmitter.addListener('DownloadResumable', (res) => {
if (res.jobId === joibId) options.resumable(res);
if (res.jobId === jobId) options.resumable(res);
}));
}

Expand Down
2 changes: 1 addition & 1 deletion RNFSManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,7 @@ + (BOOL)requiresMainQueueSetup
if (hasResumableCallback) {
params.resumableCallback = ^() {
if (self.bridge != nil)
[self sendEventWithName:@"DownloadResumable" body:nil];
[self sendEventWithName:@"DownloadResumable" body:@{@"jobId": jobId}];
};
}

Expand Down