Merged
Conversation
added 11 commits
December 5, 2024 21:22
sinejespersen
force-pushed
the
feature/3175-frontpage
branch
from
0af79b6 to
1fac691
Compare
added 10 commits
December 5, 2024 21:25
rimi-itk
requested changes
Dec 6, 2024
Contributor
rimi-itk
left a comment
rimi-itk
left a comment
There was a problem hiding this comment.
I think we should use the term “filtering” for the act of filtering.
| }`} | ||
| onClick={() => setSelectedTag(id)} | ||
| > | ||
| <span className="sr-only">Sorter listen af ruter efter ruter med tagget </span> |
Contributor
There was a problem hiding this comment.
We're not sorting, but filtering. Shouldn't this text (and other texts) be translatable?
Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
rimi-itk
approved these changes
Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/#/tickets/showTicket/3175
Description
A bunch of stuff!
localstorageScreenshot of the result