Merged
Conversation
rimi-itk
requested changes
Oct 29, 2024
Contributor
rimi-itk
left a comment
rimi-itk
left a comment
There was a problem hiding this comment.
Very good job. Some minor changes can clean up the code and make it even better.
Contributor
|
Add a GitHub Action to load the fixtures (to test that they can be loaded). Also update the documentation to tell how to load the fixtures. |
…tures_base.services.yml Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
…tures_base.services.yml Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
…sFixture.php Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
…sFixture.php Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
…sFixture.php Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
…r.php Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
…ectFixture.php Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
rimi-itk
approved these changes
Oct 30, 2024
Contributor
rimi-itk
left a comment
rimi-itk
left a comment
There was a problem hiding this comment.
Approved with some suggestions.
Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
…r.php Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
…r.php Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.